The upgrade kit costs half of a full Core one Kit (in Europe). That doesn’t sound financially wise no matter how you look at it. The MK4S still is in no way outdated to justify sacrificing it for such an expensive upgrade.
I’m not convinced the Core One is a better machine than the MK4S.
It depends a bit on your needs. I’ve upgraded mine mainly due to space concerns - it is quite a bit smaller than the mk4s with enclosure. As a positive side effect I can now print large PC models without warping - something that never worked properly even in an enclosed mk4s, probably due to the larger enclosure volume.
Semi related, I was thinking about turning my mk3 into a core xy, came across a conversion for a mk3s that looks to reuse quite a few components, ProosaXY. I really like how many different mods people have done with these old machines, definitely helps keep things useful
I didn’t plan to upgrade but this helped boost my confidence with that decision. Frankly I’m still not sure the Mk4 to mk4s upgrade was worth it for me at least.